[fix]InListPredicate wrong result (apache#10211)

* fix * reg test Co-authored-by: Wang Bo <wangbo36@meituan.com>
platoneko · Jun 17, 2022 · f7789f4 · f7789f4
1 parent 6baa694
commit f7789f4
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/be/src/olap/in_list_predicate.h b/be/src/olap/in_list_predicate.h
@@ -338,7 +338,7 @@ class InListPredicateBase : public ColumnPredicate {
                     }
                 }
 
-                if constexpr (is_opposite != (PT == PredicateType::IN_LIST)) {
+                if constexpr (!is_opposite) {
                     if (_operator(_values.find(reinterpret_cast<const T&>(data_array[idx])),
                                   _values.end())) {
                         sel[new_size++] = idx;

diff --git a/regression-test/suites/data_model/duplicate/storage/test_dup_tab_basic_int.groovy b/regression-test/suites/data_model/duplicate/storage/test_dup_tab_basic_int.groovy
@@ -152,5 +152,21 @@ PROPERTIES (
         result([[1,2,3,4]])
     }
 
+    // predicate in with two values
+    test {
+        sql """
+            select distinct userid as col from ${table1} where userid in (3,7) order by col;
+        """
+        result([[3],[7]])
+    }
+
+    // predicate not with two values
+    test {
+        sql """
+            select distinct userid as col from ${table1} where userid not in (3,7) order by col;
+        """
+        result([[11],[15],[19],[22]])
+    }
+
     sql "drop table if exists ${table1}"
 }