Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean-up #235

Merged
merged 1 commit into from
Sep 21, 2024
Merged

clean-up #235

merged 1 commit into from
Sep 21, 2024

Conversation

texadactyl
Copy link
Collaborator

modified:   native/nativeBase.go
modified:   native/nativeInit.go
modified:   native/templates.go
modified:   native/unit_II_I_test.go

@texadactyl
Copy link
Collaborator Author

texadactyl commented Sep 20, 2024

@platypusguy - I cannot do any byte array CRC32 functions (Java_java_util_zip_crc32*):

  • Byte array functions cause the the use of JNIEnv vector functions.
  • The ByteBuffer object is not yet usable as you are working on objects in general.

@texadactyl
Copy link
Collaborator Author

texadactyl commented Sep 20, 2024

@platypusguy
There is a difference between the following 2 functions, both of which take a byte array as an argument:

  • Java_java_util_zip_CRC32_updateBytes0 - needs JNIEnv function vectors.
  • ZIP_CRC32 - I used this successfully with essayer.

I'll try out the latter tomorrow with jacobin/native.

I do not know why there are 2 separate functions. Probably historical reasons.

@platypusguy platypusguy merged commit 2fc14dc into platypusguy:main Sep 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants