Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading config from file #1312

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

badsyntax
Copy link
Contributor

@badsyntax badsyntax commented Sep 9, 2021

Changes

This change fixes an error I'm experiencing when using secret files (instead of ENV vars) for config.

Tests

  • Automated tests have been added
  • This PR does not require tests

Changelog

  • Entry has been added to changelog
  • This PR does not make a user-facing change

Documentation

  • Docs have been updated
  • This change does not need a documentation update

@ukutaht
Copy link
Contributor

ukutaht commented Sep 9, 2021

Looks good to me.

@happysalada are you not using file-based config option? I'm surprised it hasn't been working the whole time

@ukutaht ukutaht merged commit 3f8af9a into plausible:master Sep 9, 2021
@badsyntax
Copy link
Contributor Author

Thanks for the quick merge! I've verified the fix using plausible/analytics:master.

@happysalada
Copy link
Contributor

I am actually waiting for a systemd update to enable load credential. (the equivalent of docker secrets for systemd)
originally I thought that update was coming fast, but it still hasn't landed.
My bad for not testing directly.
@badsyntax thanks for fixing this!

@ukutaht
Copy link
Contributor

ukutaht commented Sep 9, 2021

All good, thanks!

@badsyntax badsyntax deleted the fix-read-from-secrets branch September 9, 2021 16:09
oliver-kriska pushed a commit to payout-one/analytics that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing secrets as environment variables
3 participants