-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic PWA support #2405
base: master
Are you sure you want to change the base?
Add basic PWA support #2405
Conversation
This should be enough to fulfill the instability requirements * Add webapp manfiest * Add basic service worker ** It does nothing currently, but it is enough to fulfill the instability requirements * Add square icons per PWA reqirements (192px, 512px, SVG) ** PNGs are optimized with PNGCrush ** SVG is optimized with SVGO ** Add maskable icons for fanicer app icons
Thanks @alistair3149 ! Did you see this open PR? #1981 How would you say your PR compares to the older one? |
The older PR is incomplete and this PR covers everything in the previous PR.
|
Cheers thanks. I'll close the old one and keep this one as the one to consider. |
Is there anything I can help to move this forward? |
Each PR needs to be reviewed, tested by the core team, and integrated properly. This is not currently high on our list of priorities. For features/PRs that haven't been agreed on with the core team in advance, we can't guarantee any response times. We do want to get the list of PRs down so I might put this on our backlog sometime soon. But no promises, sorry! I really do appreciate the effort put in by all external contributors, but I hope you understand that it's the core team's responsibility to uphold quality standards. Integrating PRs takes time and effort from our side (not just on the contributor's side) and needs to be considered within the context of all our other priorities. |
No problem and appreciate the reply! I just want to make sure that all work has been done and it is ready for handoff. Hope to see it integrated soon! |
Hi @ukutaht I know you mentioned back in 2022 that you couldn't guarantee any response times, but is there any update on the status of this PR 2 years down the track? I noticed there is a CLAassistant message the might need to be seen to by @alistair3149? |
Sorry no update on this. PWA hasn't been a priority for us (yet) |
Changes
Should be enough to fulfill the installability requirements (#181):
Tests
Changelog
Documentation
Dark mode
Notes
There are still some potential PWA improvements can be added in the future, but sadly I don't know enough about Plausible or Elixir to add those myself. Maybe someone can take a look:
On an unrelated note, I realized that the original SVG icon has some dirty pathing where the "P" icon does not line up with the circle. Not sure if it is intended so I left that there. The PNG icons in the static folder can be further reduced in file sizes as well to save some bandwidth.
This is my first time committing a PR here, please let me know if there is anything you need!