Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC #3706

Closed
wants to merge 3 commits into from
Closed

OIDC #3706

wants to merge 3 commits into from

Conversation

kloenk
Copy link

@kloenk kloenk commented Jan 21, 2024

This is based on #3705 and contains ideas from #3170

Changes

Add OIDC support for user creation and login

Tests

  • Automated tests have been added
  • This PR does not require tests

Changelog

  • Entry has been added to changelog
  • This PR does not make a user-facing change

Documentation

  • Docs have been updated
  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode
  • This PR does not change the UI

@kloenk
Copy link
Author

kloenk commented Jan 21, 2024

the config :plausible, Plausible.Auth.OIDC, :site_membership_claim can now be a function that accepts a claims map and returns a list of either strings or a tuple of 2 strings, the first being the domain, the second being the role in that domain.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kloenk
Copy link
Author

kloenk commented Mar 24, 2024

As part is taken from another pr I'm not sure if I can fully grant this rights. Sorry for not seeing the cla before

@ukutaht
Copy link
Contributor

ukutaht commented Mar 26, 2024

@kloenk Thank you for your contribution.

If I understand correctly, this PR will switch the login functionality for the whole Plausible application based on a config variable. This only makes sense in self-hosted / community edition for smaller teams since it treats Plausible as a single-tenant application.

The way I see it, we need to build team/organization accounts first and any sort of SSO features are a natural extension of that. Sadly this PR does not seem to fit into that story. Also sadly, team accounts isn't something we are tackling just yet. The plan is to work on this towards the end of this year.

@kloenk kloenk closed this Mar 26, 2024
@ukutaht ukutaht mentioned this pull request Apr 23, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants