Remove trial mentions from site emails in CE #4668
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukutaht
approved these changes
Oct 15, 2024
ruslandoga
force-pushed
the
remove-trial-mention-from-site-setup-email
branch
from
ef6da73
to
4d04718
Compare
ruslandoga
commented
Oct 16, 2024
| <%= if Plausible.ee?() do %> | ||
| your free 30-day trial of | ||
| <% end %> | ||
| Plausible, a simple and privacy-friendly website analytics tool. <br /><br /> |
There was a problem hiding this comment.
Trial upgrade email uses similar wording (just "Plausible") but it's not really used in CE:
There was a problem hiding this comment.
I'd like to double-check if it's OK to use "Plausible" in CE
There was a problem hiding this comment.
Yes it's fine. I think "Plausible Community Edition" would be better though to be extra explicit.
I don't think the trial upgrade email should be sent at all in CE, though, doesn't seem to make much sense in self-hosting context?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR continues #4496 and updates two other site setup emails.
Related: #2213 (comment)
Tests
Changelog
Documentation
Dark mode