Log mailer errors in CE #4846
Log mailer errors in CE #4846
Conversation
ruslandoga
force-pushed
the
log-mailer-errors-in-ce
branch
from
9cac975
to
3795eb2
Compare
| @@ -28,6 +28,16 @@ defmodule Plausible.Mailer do | |||
| end | |||
| end | |||
|
|
|||
| defp handle_error(error) when is_exception(error) do | |||
There was a problem hiding this comment.
Mua errors are Exception.ts so they would be handled by this clause.
| # this message is ignored by Sentry, but it's useful in CE | ||
| Logger.error("Failed to send e-mail:\n\n " <> Exception.format(:error, error), | ||
| # Sentry report is built entirely from crash_reason | ||
| crash_reason: {error, _stacktrace = []} |
There was a problem hiding this comment.
I can add :message or :fingerprint option like "Failed to send e-mail" to make it appear the same way as before in Sentry if that's needed.
I don't think this clause would be reached in EE under normal circumstances. The first handle_error (that handles API response) would be the one that matches since all Bamboo.Postmark errors are Bamboo.ApiErrors with a :response field.
Hm... there is no :response field in https://github.com/beam-community/bamboo/blob/main/lib/bamboo/api_error.ex so the first handle_error won't ever match.
Context for the adapter used in EE (AFAIK): https://github.com/plausible/bamboo_postmark/blob/ed55d273dac6c9c121e86f04823acaa9be33114f/lib/bamboo/postmark_adapter.ex#L25-L40 -- it calls Bamboo.ApiError.build_api_error which returns %Bamboo.ApiError{message: "not json"}
There was a problem hiding this comment.
Was #2361 verified to work at the time? It doesn't seem like %Bamboo.ApiError{} ever contained :response field: https://github.com/beam-community/bamboo/commits/82ff20890821f365a1ea9501acc0e0d79288d290/lib/bamboo/api_error.ex
Changes
This PR improves Plausible.Mailer error messages in CE.
It tries to keep changes to a minimum and only changes how exceptions are logged.
Similar to #4657
Requested in #4844 (comment)
Tests
Changelog
Documentation
Dark mode