Team Management UI #4997
Open
Team Management UI #4997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerosol
force-pushed
the
team-people-settings
branch
from
e8872ac to
fab8583
Compare
aerosol
commented
Feb 4, 2025
aerosol
commented
Feb 4, 2025
aerosol
force-pushed
the
team-people-settings
branch
from
c6d12bd to
0e5d9ec
Compare
Will be needed later, when operations are applied in bulk and notifications go out only when transaction succeeded.
Will be used in setup but also later on, in membership settings.
By sharing the same form layout in both views, and enabling promoting guests to team members in a separate section.
aerosol
force-pushed
the
team-people-settings
branch
from
2d92d34 to
5a78106
Compare
aerosol
requested review from
zoldar and
ukutaht
and removed request for
zoldar
aerosol
commented
Feb 5, 2025
aerosol
commented
Feb 5, 2025
aerosol
commented
Feb 5, 2025
aerosol
commented
Feb 5, 2025
lib/plausible_web/templates/site/membership/invite_member_form.html.heex
Show resolved
Hide resolved
|
ukutaht
reviewed
Feb 5, 2025
ukutaht
reviewed
Feb 5, 2025
ukutaht
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR:
Team.Management.Layoutabstraction to handleTeams.Invitations states, combined withTeams.Memberships - allowing free arrangement of them, in such way so that changes can be applied in a single transactionPromEx.Plugins.Obanduring tests, due to connection ownership clashesTeam setup allows enqueuing batched operations before the changes are submitted, while team settings section updates team layout immediately in-place.
The UI is mostly ready for handling multiple owners, although requires a merger with work that's parallel. Billing role will happily crash Live Views, since it's not implemented at all and not even enumerated properly in schemas and such. This is expected and proper regression indicators were planted.
The views are feature-flagged before we implement team role based access enforcement.
team/setuproute is normally accessible just once (given the setup completes), but you can revisit it temporarily by adding?dev=trueto the URL. Reseeding before first try is recommended.Tests
Changelog
Documentation
Dark mode