add Elixir v1.18

plausible · Dec 21, 2024 · 710f49d · 710f49d
1 parent 807bcb6
commit 710f49d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 18 deletions.
diff --git a/.github/workflows/mix.yml b/.github/workflows/mix.yml
@@ -22,7 +22,11 @@ jobs:
             otp: 27
             clickhouse: latest
             timezone: UTC
-          - elixir: 1.17
+          - elixir: 1.18
+            otp: 27
+            clickhouse: latest
+            timezone: UTC
+          - elixir: 1.18
             otp: 27
             clickhouse: latest
             timezone: Europe/Berlin

diff --git a/lib/ecto/adapters/clickhouse.ex b/lib/ecto/adapters/clickhouse.ex
@@ -283,23 +283,9 @@ defmodule Ecto.Adapters.ClickHouse do
 
   @dialyzer {:no_return, update: 6}
   @impl Ecto.Adapter.Schema
-  def update(adapter_meta, %{source: source, prefix: prefix}, fields, params, returning, opts) do
-    {fields, field_values} = :lists.unzip(fields)
-    filter_values = Keyword.values(params)
-    sql = @conn.update(prefix, source, fields, params, returning)
-
-    Ecto.Adapters.SQL.struct(
-      adapter_meta,
-      @conn,
-      sql,
-      :update,
-      source,
-      params,
-      field_values ++ filter_values,
-      :raise,
-      returning,
-      opts
-    )
+  def update(_adapter_meta, _schema_meta, _fields, _params, _returning, _opts) do
+    raise ArgumentError,
+          "ClickHouse does not support UPDATE statements -- use ALTER TABLE ... UPDATE instead"
   end
 
   # TODO