structured migration options #116
Conversation
| @@ -2065,6 +2102,10 @@ defmodule Ecto.Adapters.ClickHouse.ConnectionTest do | |||
| ] | |||
| end | |||
|
|
|||
| # TODO? | |||
| @tag :skip | |||
| test "drop constraint on cluster" | |||
There was a problem hiding this comment.
https://hexdocs.pm/ecto_sql/Ecto.Migration.Constraint.html doesn't have :options field. We can hack around and pass cluster in :comment though :)
There was a problem hiding this comment.
We can also open a PR into Ecto to add constraint.options
There was a problem hiding this comment.
I'm relatively new to ClickHouse, so maybe I'm just not fully aware, but according to the docs, constraints are created and dropped using ALTER TABLE statements https://clickhouse.com/docs/en/sql-reference/statements/alter/constraint
There was a problem hiding this comment.
Yes, but that's not the issue. The issue is that we we can't pass any :options to https://hexdocs.pm/ecto_sql/Ecto.Migration.html#constraint/3
ruslandoga
force-pushed
the
better-migration-options
branch
10 times, most recently
from
9fc41b8 to
a3dee69
Compare
ruslandoga
force-pushed
the
better-migration-options
branch
from
a3dee69 to
7720530
Compare
| ```elixir | ||
| table_options = [cluster: "my-cluster"] | ||
| engine_options = [order_by: "tuple()"] | ||
| optiosn = table_options ++ engine_options |
|
@ruslandoga this looks great! |
This PR attempts to add structured migration options as proposed in #115 (comment)