Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spine mipmap #36

Merged
merged 16 commits into from
Jun 25, 2024
Merged

fix: spine mipmap #36

merged 16 commits into from
Jun 25, 2024

Conversation

Zyie
Copy link
Collaborator

@Zyie Zyie commented Jun 20, 2024

this was pulled from the open source assetpack and I believe this helps fix the issue with mipmapping spine files

@Zyie Zyie requested a review from GoodBoyDigital June 20, 2024 14:39
Copy link

@GoodBoyDigital GoodBoyDigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, has this fix been verified? can we add a test pls? Thanks!

@Zyie
Copy link
Collaborator Author

Zyie commented Jun 25, 2024

will follow up in separate PR

https://github.com/play-co/pixi-external/issues/89

Base automatically changed from feat/multi-pack to main June 25, 2024 09:02
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR title doesn't match the required format. The title should be in the conventional commit (https://www.conventionalcommits.org/en/v1.0.0-beta.4/) format. e.g.

chore: add pr title workflow

@Zyie Zyie changed the title fix spine mipmap fix: spine mipmap Jun 25, 2024
@Zyie Zyie merged commit 83d4add into main Jun 25, 2024
4 of 5 checks passed
@Zyie Zyie deleted the fix/spine-mipmap branch June 25, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants