Reproject fix (#5860)

playcanvas · Nov 28, 2023 · 02e16c4 · 02e16c4
1 parent 811de63
commit 02e16c4
Showing 1 changed file with 17 additions and 12 deletions.
diff --git a/src/scene/graphics/reproject-texture.js b/src/scene/graphics/reproject-texture.js
@@ -396,6 +396,7 @@ void main(void) {
  * 'phong', 'ggx'. Default depends on specularPower.
  * @param {import('../../core/math/vec4.js').Vec4} [options.rect] - Optional viewport rectangle.
  * @param {number} [options.seamPixels] - Optional number of seam pixels to render
+ * @returns {boolean} True if the reprojection was applied and false otherwise (e.g. if rect is empty)
  */
 function reprojectTexture(source, target, options = {}) {
     // maintain backwards compatibility with previous function signature
@@ -414,6 +415,15 @@ function reprojectTexture(source, target, options = {}) {
         Debug.deprecated('please use the updated pc.reprojectTexture API.');
     }
 
+    // calculate inner width and height
+    const seamPixels = options.seamPixels ?? 0;
+    const innerWidth = (options.rect?.z ?? target.width) - seamPixels * 2;
+    const innerHeight = (options.rect?.w ?? target.height) - seamPixels * 2;
+    if (innerWidth < 1 || innerHeight < 1) {
+        // early out if inner space is empty
+        return false;
+    }
+
     // table of distribution -> function name
     const funcNames = {
         'none': 'reproject',
@@ -475,19 +485,12 @@ function reprojectTexture(source, target, options = {}) {
     const constantParams2 = device.scope.resolve("params2");
 
     const uvModParam = device.scope.resolve("uvMod");
-    if (options?.seamPixels) {
-        const p = options.seamPixels;
-        const w = options.rect ? options.rect.z : target.width;
-        const h = options.rect ? options.rect.w : target.height;
-
-        const innerWidth = w - p * 2;
-        const innerHeight = h - p * 2;
-
+    if (seamPixels > 0) {
         uvModParam.setValue([
-            (innerWidth + p * 2) / innerWidth,
-            (innerHeight + p * 2) / innerHeight,
-            -p / innerWidth,
-            -p / innerHeight
+            (innerWidth + seamPixels * 2) / innerWidth,
+            (innerHeight + seamPixels * 2) / innerHeight,
+            -seamPixels / innerWidth,
+            -seamPixels / innerHeight
         ]);
     } else {
         uvModParam.setValue([1, 1, 0, 0]);
@@ -535,6 +538,8 @@ function reprojectTexture(source, target, options = {}) {
     }
 
     DebugGraphics.popGpuMarker(device);
+
+    return true;
 }
 
 export { reprojectTexture };