Add webpack ignore (#6359)

playcanvas · May 14, 2024 · 9751ca8 · 9751ca8
1 parent 692f2a7
commit 9751ca8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/utils/plugins/rollup-dynamic.mjs b/utils/plugins/rollup-dynamic.mjs
@@ -20,17 +20,18 @@ export function dynamicImportLegacyBrowserSupport() {
 }
 
 /**
- * This rollup plugin transform code with import statements and adds a \/* vite-ignore *\/ comment to supress vite warnings
+ * This rollup plugin transform code with import statements and adds a \/* vite-ignore *\/ comment to suppress bundler warnings
  * generated from dynamic-import-vars {@link https://github.com/rollup/plugins/tree/master/packages/dynamic-import-vars#limitations}
+ * {@link https://webpack.js.org/api/module-methods/#dynamic-expressions-in-import}
  *
  * @returns {import('rollup').Plugin} The rollup plugin
  */
-export function dynamicImportViteSupress() {
+export function dynamicImportBundlerSuppress() {
     return {
-        name: 'dynamic-import-vite-suppress',
+        name: 'dynamic-import-bundler-suppress',
         transform(code, id) {
             return {
-                code: code.replace(/import\(([^'])/g, 'import(/* @vite-ignore */$1'),
+                code: code.replace(/import\(([^'])/g, 'import(/* @vite-ignore */ /* webpackIgnore: true */ $1'),
                 map: null
             };
         }

diff --git a/utils/rollup-build-target.mjs b/utils/rollup-build-target.mjs
@@ -12,7 +12,7 @@ import { visualizer } from 'rollup-plugin-visualizer';
 import { shaderChunks } from './plugins/rollup-shader-chunks.mjs';
 import { engineLayerImportValidation } from './plugins/rollup-import-validation.mjs';
 import { spacesToTabs } from './plugins/rollup-spaces-to-tabs.mjs';
-import { dynamicImportLegacyBrowserSupport, dynamicImportViteSupress } from './plugins/rollup-dynamic.mjs';
+import { dynamicImportLegacyBrowserSupport, dynamicImportBundlerSuppress } from './plugins/rollup-dynamic.mjs';
 import { treeshakeIgnore } from './plugins/rollup-treeshake-ignore.mjs';
 
 import { version, revision } from './rollup-version-revision.mjs';
@@ -210,7 +210,7 @@ function buildTarget({ moduleFormat, buildType, input = 'src/index.js', dir = 'b
             isDebug ? engineLayerImportValidation(input) : undefined,
             !isDebug ? strip({ functions: STRIP_FUNCTIONS }) : undefined,
             babel(babelOptions(isDebug, isUMD)),
-            !isUMD ? dynamicImportViteSupress() : undefined,
+            !isUMD ? dynamicImportBundlerSuppress() : undefined,
             !isDebug ? spacesToTabs() : undefined
         ]
     };