-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public AssetListLoader & examples update #4149
Conversation
Looks good to me, in general. I've left a bunch of comments. However, should we take a moment to review the |
Would it be possible to write a new API in similar format in the first post of this PR? |
Sure, I've added this in. |
I just wonder if the |
It's not used by the examples but it allows other parts of an application to subscribe to the loading of these assets without triggering the load itself. |
Yeah you're right, i've included this in the list of example browser polyfills. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving, nicely done
This PR brings back the AssetListLoader class which allows an array of assets to be loaded before the 'ready' callback is called. This class is made public and includes unit tests.
The examples browser now makes use of the AssetListLoader for asset loading in all examples. The examples browser therefore no longer needs to hoist the application instantiation in each example in order to preload example assets in.
New Public API:
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.