-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shader processor improvements related to bind groups format #4410
Conversation
Co-authored-by: Will Eastcott <will@playcanvas.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with small comment. Just checking, does this code gets stripped out of the built engine? (the webgpu-only stuff)
The shader processor is stripped out for now, as its imported only by WebgpuShader, which is not part of the engine yet. |
Note: This does not execute on WebGl (currently)