-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standard shader compatibility improvements for WebGPU #4568
Conversation
mvaligursky
commented
Aug 19, 2022
•
edited
Loading
edited
- 2d texture sampling is using texture2DBias instead of texture2D to allow macro replacement for WebGPU
- Uniform buffer handles additional uniform types - alignment, setup
- adding extensions earlier in the shader code to avoid warnings
This seems to touch a lot of front end chunks. Are we concerned this is going to break a lot of projects that override chunks? |
I'm not, old chunks still work, just on WebGPU if they use the bias. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please get 1 more approval on this one... 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably move the chunk changes to another PR just to keep them separate, seeing as they take up the majority of the changes in this PR.
It's painful to split PRs where lots of little things change to get shader compilation moving, I'm not sure its worth it. |