Refactoring to get more of the standard shader compile for WebGPU #4575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mvaligursky
commented
Aug 22, 2022
•
mvaligursky
commented
- WIP on loading glb model and rendering it on WebGPU device
- moved bone limits from webgl device to the device to share it across platforms
- updated shader processor to handle precision specification for uniforms
- updated shader processor to ignore out keywords for now, as those are handled differently for now (we only need more generic solution when we add support for MRT)
Open
kungfooman
reviewed
Aug 22, 2022
kungfooman
reviewed
Aug 22, 2022
Co-authored-by: Hermann Rolfes <lama12345@gmail.com>
Co-authored-by: Hermann Rolfes <lama12345@gmail.com>
slimbuck
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.