Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial cubemap support for WebGPU #4911

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Partial cubemap support for WebGPU #4911

merged 1 commit into from
Dec 6, 2022

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Dec 6, 2022

  • cubemap can be used by the shader, and it can be used as a render target
  • upload of texture data into a cubemap is still not supported
  • the render target cubemap is flipped upside-down. Setting RenderTarget.flipY to false instead of true (as required by WebGl) fixes this. This will be addressed at a later stage.
  • refactor of shader precision code generation set it up for WebGPU shaders
  • improved handling of failed-to-compile webgpu shaders by skipping the drawCall, instead of trying to render it and bringing down the whole rendering.
render.to.cubemap.mov

@mvaligursky mvaligursky self-assigned this Dec 6, 2022
@mvaligursky mvaligursky added feature area: graphics Graphics related issue labels Dec 6, 2022
@mvaligursky mvaligursky mentioned this pull request Dec 6, 2022
@mvaligursky mvaligursky merged commit 4c16f9a into main Dec 6, 2022
@mvaligursky mvaligursky deleted the mv-webgpu-cubemap branch December 6, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants