-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mipmap generation for WebGPU 2D textures #5275
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
slimbuck
reviewed
Apr 27, 2023
slimbuck
approved these changes
Apr 28, 2023
Co-authored-by: Will Eastcott <will@playcanvas.com>
Co-authored-by: Will Eastcott <will@playcanvas.com>
willeastcott
approved these changes
Apr 28, 2023
Co-authored-by: Will Eastcott <will@playcanvas.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changea to the texture loading flow:
Background: WebGPU creates texture immediatelly, instead of on first use, and it would have to handle texture re-creation.
Limitation: WebGPU does not currently allow texture.mipmaps to be changed after the creation. Subject to discussion / change / further work.
Other changes:
References:
@toji for WebGPU Textures - best practices: https://toji.dev/webgpu-best-practices/img-textures#generating-mipmaps
Result - textures no longer shimmer
mipmaps.mov