Update to vertex format handling and morphing on WebGPU #5319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
slimbuck
approved these changes
May 11, 2023
Comment on lines
+34
to
+40
| #ifdef WEBGPU | ||
| ivec2 morphUV = getTextureMorphCoords(); | ||
| vec3 morphNormal = texelFetch(morphNormalTex, ivec2(morphUV), 0).xyz; | ||
| #else | ||
| vec2 morphUV = getTextureMorphCoords(); | ||
| vec3 morphNormal = texture2D(morphNormalTex, morphUV).xyz; | ||
| #endif |
There was a problem hiding this comment.
Indentation here looks inconsistent.
There was a problem hiding this comment.
good point: Fixed incorrect indentation in normal.js chunk
thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5262
Changes:
MeshMorphMany example has been changes to use a morph-stress-test example instead of procedural geometry, and it reveals issues in a cleaner way. The example has been disabled for WebGPU temporarily, due to the issues with vertex-id buffer passing to GPU and will be fixed separately.