-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebXR Mesh Detection #5791
Merged
Merged
WebXR Mesh Detection #5791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvaligursky
reviewed
Nov 30, 2023
mvaligursky
reviewed
Nov 30, 2023
mvaligursky
reviewed
Nov 30, 2023
mvaligursky
reviewed
Nov 30, 2023
Great PR and the example! Thanks so much @Maksims . |
Made a quick update based on comments, and removed ID as it is nowadays redundant, as Map is widely used for indexes. |
mvaligursky
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration of WebXR Mesh Detection API.
Tested on Quest 3. This data on Quest 3 comes from pre-scanned information and added furniture. You can trigger a request for manual room capture, so users can provide refined information.
Includes an example of building geometry and labeling them.
This API design based on planeDetection API.
Test link: https://examples.playcanvas.meta.space/#/xr/ar-mesh-detection
This API can enable many cool AR applications:
New APIs:
Fixes #5699
a95e570cc5a5ba934b551e679016a956.mp4
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.