Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for video textures #5836

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Fix for video textures #5836

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
08eb4c6
set and test size correctly
slimbuck Nov 21, 2023
8c55bae
revert
slimbuck Nov 21, 2023
0a60236
revert revert
slimbuck Nov 21, 2023
74a4a1a
only set width and height on level 0
slimbuck Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/platform/graphics/webgl/webgl-texture.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,10 +512,13 @@ class WebglTexture {
}
}

const w = mipObject.width || mipObject.videoWidth;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?? would probably be better

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For video textures width and height are 0.

const h = mipObject.height || mipObject.videoHeight;

// Upload the image, canvas or video
device.setUnpackFlipY(texture._flipY);
device.setUnpackPremultiplyAlpha(texture._premultiplyAlpha);
if (this._glCreated && mipObject.width === texture._width && mipObject.height === texture._height) {
if (this._glCreated && texture._width === w && texture._height === h) {
gl.texSubImage2D(
gl.TEXTURE_2D,
mipLevel,
Expand All @@ -533,6 +536,11 @@ class WebglTexture {
this._glPixelType,
mipObject
);

if (mipLevel === 0) {
texture._width = w;
texture._height = h;
}
}
} else {
// Upload the byte array
Expand Down