Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color grab pass can be used for custom render pass rendering #5866

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Color grab pass can be used for custom render pass rendering #5866

merged 1 commit into from
Nov 29, 2023

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Nov 29, 2023 •
edited
Loading

  • RenderPassColorGrab refactoring to make it easily useable as a custom pass
  • render passes interface extended to handle changing loadOps
  • render action render pass handles clearing correctly
  • updated example with integrated bloom and color grab passes
bloom.mov

@mvaligursky mvaligursky self-assigned this Nov 29, 2023
@mvaligursky mvaligursky added feature area: graphics Graphics related issue labels Nov 29, 2023
slimbuck
slimbuck reviewed Nov 29, 2023
View reviewed changes
examples/src/examples/graphics/post-processing.mjs
@@ -123,7 +142,9 @@ async function example({ canvas, deviceType, assetPath, glslangPath, twgslPath,
glslangUrl: glslangPath + 'glslang.js',
twgslUrl: twgslPath + 'twgsl.js',

// WebGPU does not currently support antialiased depth resolve, disable it till we implement a shader resolve solution
// The scene is rendered to an antialiased texture, so we disable antialiasing on the canvas
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you referring to 2d UI in which case msaa doesn't help anyway?

Can't you get rid of depth buffer too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point! depth/stencil on the backbuffer is useless, but when I try to remove it, I get some exception on WebGPU renderer (WebGL is fine) .. I'll fix in a separate PR

slimbuck
slimbuck approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@slimbuck slimbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving with comment

@mvaligursky mvaligursky merged commit 286f92a into main Nov 29, 2023
7 checks passed
@mvaligursky mvaligursky deleted the mv-grabpass-bloom branch November 29, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

@marklundin marklundin Awaiting requested review from marklundin

@isumygin-sc isumygin-sc Awaiting requested review from isumygin-sc

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @slimbuck