Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Framebuffer clear flags on the Layer were not correctly used #5875

Merged
merged 1 commit into from
Dec 1, 2023
Merged

[Fix] Framebuffer clear flags on the Layer were not correctly used #5875

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/scene/composition/layer-composition.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,9 +314,10 @@ class LayerComposition extends EventHandler {

// clear flags - use camera clear flags in the first render action for each camera,
// or when render target (from layer) was not yet cleared by this camera
const needsClear = cameraFirstRenderAction || !used;
if (needsClear) {
renderAction.setupClears(needsClear ? camera : undefined, layer);
const needsCameraClear = cameraFirstRenderAction || !used;
const needsLayerClear = layer.clearColorBuffer || layer.clearDepthBuffer || layer.clearStencilBuffer;
if (needsCameraClear || needsLayerClear) {
renderAction.setupClears(needsCameraClear ? camera : undefined, layer);
}

return renderAction;
Expand Down