Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing sky properties fixes #5904

Merged
merged 11 commits into from
Dec 19, 2023
Merged

Exposing sky properties fixes #5904

Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
796d96a
Added new properties to scene for new skybox
kpal81xd Dec 18, 2023
96fe6ec
Reordered scene setting skybox scale definition
kpal81xd Dec 18, 2023
2b3f673
Removed forwarding of skyType component - already exposed in sky
kpal81xd Dec 18, 2023
c3fb11a
Moved applying properties for position, scale and tripod to applySett…
kpal81xd Dec 18, 2023
f84401d
set position and scale properties directy onto node in sky; renamed t…
kpal81xd Dec 18, 2023
6cb5ad6
added node rotation setting
kpal81xd Dec 18, 2023
7e196c7
Rename sky mesh properties to include mesh in their names
kpal81xd Dec 18, 2023
7411d93
Merge branch 'main' into expose-sky
kpal81xd Dec 19, 2023
a2d55cf
applySettings to include type change
kpal81xd Dec 19, 2023
c56652e
null check for skyType
kpal81xd Dec 19, 2023
0fe4e79
Update src/scene/skybox/sky.js
kpal81xd Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/scene/skybox/sky.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ class Sky {


applySettings(render) {
this.type = render.skyType ?? this.type;
kpal81xd marked this conversation as resolved.
Show resolved Hide resolved
this.node.setLocalPosition(new Vec3(render.skyMeshPosition ?? [0, 0, 0]));
this.node.setLocalEulerAngles(new Vec3(render.skyMeshRotation ?? [0, 0, 0]));
this.node.setLocalScale(new Vec3(render.skyMeshScale ?? [1, 1, 1]));
Expand Down