Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental opacity dithering for splats #5905

Merged
merged 6 commits into from
Dec 20, 2023
Merged

Experimental opacity dithering for splats #5905

merged 6 commits into from
Dec 20, 2023

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Dec 19, 2023 •
edited
Loading

  • experimental support to render splats without sorting and without alpha blending, depending on opacity dithering.
  • this does not work too well by itself, and is disabled by default. It would require a better version of stochastic transparency (https://luebke.us/publications/StochTransp-slides.pdf) and TAA.
splat-dither1080.mov

@mvaligursky mvaligursky self-assigned this Dec 19, 2023
@mvaligursky mvaligursky added feature area: graphics Graphics related issue labels Dec 19, 2023
@mvaligursky mvaligursky requested a review from a team December 19, 2023 15:16
@kungfooman
Copy link
Collaborator

kungfooman commented Dec 19, 2023 •
edited
Loading

I can't watch .mov files in Chrome, so I just converted via ffmpeg:

splat-dither.mp4

@LeXXik Yep, must be a Linux issue (not the first and probably not the last one)

Merge branch 'main' into mv-splat-dithering
ef4f37f 
# Conflicts:
#	src/scene/materials/standard-material.js
@LeXXik
Copy link
Contributor

LeXXik commented Dec 19, 2023

I can't watch .mov files in Chrome, so I just converted via ffmpeg:

Is it Linux related? I can watch them fine on Windows Chrome.

@mvaligursky mvaligursky merged commit c65677c into main Dec 20, 2023
@mvaligursky mvaligursky deleted the mv-splat-dithering branch December 20, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mvaligursky @kungfooman @LeXXik @willeastcott