Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to fringe offset to be independent of the render target resolution #5911

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Fix to fringe offset to be independent of the render target resolution #5911

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b373080
Fix to fringe offset to be independent of the render target resolution
Dec 22, 2023
d499a60
Update extras/render-passes/render-pass-compose.js
mvaligursky Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion extras/render-passes/render-pass-compose.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,8 @@ class RenderPassCompose extends RenderPassShaderQuad {
}

if (this._fringingEnabled) {
this.fringingIntensityId.setValue(this.fringingIntensity / this.sceneTexture.height);
// relative fo a fixed texture resolution to preserve size regardless of the resolution
mvaligursky marked this conversation as resolved.
Show resolved Hide resolved
this.fringingIntensityId.setValue(this.fringingIntensity / 1024);
}

super.execute();
Expand Down