Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused Texture._isRenderTarget #5913

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Remove unused Texture._isRenderTarget #5913

merged 1 commit into from
Jan 7, 2024

Conversation

erikdubbelboer
Copy link
Contributor

Code that used it was removed at some point.

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@erikdubbelboer
Remove unused Texture._isRenderTarget
cc2dc6e 
Code that used it was removed at some point.
@slimbuck slimbuck assigned slimbuck and mvaligursky and unassigned slimbuck Jan 3, 2024
@willeastcott
Copy link
Contributor

willeastcott commented Jan 7, 2024 •
edited
Loading

For the history, the usage of the _isRenderTarget property was added in this PR: #2527

And it was removed here: #3751 (by @slimbuck)

@willeastcott willeastcott reopened this Jan 7, 2024
willeastcott
willeastcott approved these changes Jan 7, 2024
View reviewed changes
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks. 🙏

@willeastcott willeastcott merged commit c7bbe1f into playcanvas:main Jan 7, 2024
14 checks passed
@willeastcott willeastcott added bug area: graphics Graphics related issue labels Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erikdubbelboer @willeastcott @slimbuck @mvaligursky