Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thumbnail creation on Windows #5929

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Fix thumbnail creation on Windows #5929

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bfa394
Fix thumbnail creation on Windows
willeastcott Jan 8, 2024
cf3a599
Merge branch 'main' into fix-thumbs
willeastcott Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion examples/scripts/thumbnails.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ async function main() {
// npx serve dist --config ../serve.json
// Reason: https://github.com/vercel/serve/issues/732
// (who *ever* thought that stripping .html was a good idea in the first place...)
const server = spawn('serve', ['dist', '-l', port, '--no-request-logging', '--config', '../serve.json']);
const cmd = process.platform === 'win32' ? 'npx.cmd' : 'npx';
const server = spawn(cmd, ['serve', 'dist', '-l', port, '--no-request-logging', '--config', '../serve.json']);
await sleep(1000); // give a second to spawn server
console.log("Starting puppeteer screenshot process");
try {
Expand Down