Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove type global function #5942

Merged
merged 6 commits into from
Jan 15, 2024
Merged

Remove type global function #5942

merged 6 commits into from
Jan 15, 2024

Conversation

slimbuck
Copy link
Member

I noticed the following unused core function being included in an optimised, tree-shaken build of an engine app:

Screenshot 2024-01-15 at 13 36 39

This PR changes the implementation so the function will be removed correctly.

@slimbuck slimbuck requested a review from a team January 15, 2024 13:51
@slimbuck slimbuck self-assigned this Jan 15, 2024
src/core/core.js Outdated Show resolved Hide resolved
src/core/core.js Outdated Show resolved Hide resolved
@slimbuck slimbuck merged commit 65704cb into playcanvas:main Jan 15, 2024
7 checks passed
@slimbuck slimbuck deleted the typefix branch January 15, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants