-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor JSDocs for events #5974
Conversation
With replacing event string with constants, is there info on how V8 actually handles constant strings in the code? |
@Maksims I don't have any information on that, but:
|
Will they still show in normal JSDoc ( Somehow strange that we have to increase build size for docs. |
Is there a way to make new docs respect |
We aren't the first asking for this feature: https://github.com/TypeStrong/typedoc/issues?q=jsdoc+event Unfortunately the maintainer doesn't care about
|
TypeDoc/ |
|
||
/** | ||
* Fired when a touch is canceled on the component. Only fired when useInput is true. The | ||
* handler is passed an {@link ElementTouchEvent}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so glad you preserved the types of arguments too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What an effort!
@kpal81xd - any events you might need to update similarly for the Gizmos?
Refactor the JSDoc blocks for all events in the engine:
add
andadd:[name]
have been combined underadd
(as variants).tsc
does not see the events). The static string is just a mechanism to document the event - the developer is not expected to use it in their code (although there's no harm in doing that).@example
tag written in modern JS.This PR enables all events to now show in the new TypeDoc API reference manual. As an example, here's the new look of the
SpriteComponent
API ref page:And:
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.