Implement changes to WebGPU timestamp-query #6001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove call to GPURenderPassEncoder.writeTimestamp as it is not part of the spec anymore, and was removed by Chrome. It is also not needed anymore. The new interface, GPURenderPassDescriptor.timestampWrites was already implemented so nothing is needed there.
erikdubbelboer
force-pushed
the
re-enable-supportsTimestampQuery
branch
from
4711709 to
1511a0d
Compare
mvaligursky
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove call to
GPURenderPassEncoder.writeTimestampas it is not part of the spec anymore, and was removed by Chrome. It is also not needed anymore.The new interface,
GPURenderPassDescriptor.timestampWriteswas already implemented so nothing is needed there.Fixes #5989
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.