Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactor to ForwardRenderer.renderForwardLayer to allow additional options #6035

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Small refactor to ForwardRenderer.renderForwardLayer to allow additional options #6035

merged 2 commits into from
Feb 2, 2024

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Feb 2, 2024 •
edited
Loading

  • this allows it to be used by the Lightmapper, which does not use layer to specify mesh instances to render, but providers a list instead
  • also passing Camera instead of CameraComponent, as that is not needed there

Note: it does not fix the lightmapper issue as was hoped, related to #6016

@mvaligursky mvaligursky self-assigned this Feb 2, 2024
@mvaligursky mvaligursky added area: graphics Graphics related issue enhancement labels Feb 2, 2024
@mvaligursky mvaligursky requested a review from a team February 2, 2024 12:19
@mvaligursky mvaligursky merged commit 21e3616 into main Feb 2, 2024
7 checks passed
@mvaligursky mvaligursky deleted the mv-renderForwardLayer-improvement branch February 2, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @slimbuck