New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small clean up to depth rendering #6037

Merged

mvaligursky merged 1 commit into main from mv-depth-rendering-cleanup

Feb 2, 2024

Contributor

mvaligursky commented Feb 2, 2024 •

edited

Loading

render pass based rendering allocates the depth buffer internally, instead of letting the render target managing this, to allow us to render depth pre-pass to the same target (separate PR)
removed _noDepthDrawGl1 flag on mesh instance that is not needed. This makes depth rendering on gl1 to match the one on gl2, and is based on the material.depthWrite flag.


          Small clean up to depth rendering

b88b0f4

mvaligursky self-assigned this

mvaligursky added area: graphics enhancement labels

mvaligursky requested a review from a team

February 2, 2024 14:20

willeastcott approved these changes

View reviewed changes

mvaligursky merged commit 204b64c into main

7 checks passed

mvaligursky deleted the mv-depth-rendering-cleanup branch

February 2, 2024 14:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: graphics enhancement