Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor of the shader validation #6081

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Refactor of the shader validation #6081

merged 3 commits into from
Feb 22, 2024

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Feb 22, 2024 •
edited
Loading

Shader does not get validated when it gets assigned on a device, but when it's used for rendering. Benefits:

  • better error reporting / skipping of failed shader in other places than forward renderer
  • allows the validation to be done differently per platform (shader level on WebGL, but render pipeline level on WebGPU)
  • allows unified handling of async shader / render pipeline compilation on WebGL / WebGPU (follow up PR)

@mvaligursky mvaligursky self-assigned this Feb 22, 2024
@mvaligursky mvaligursky added area: graphics Graphics related issue enhancement labels Feb 22, 2024
@mvaligursky mvaligursky requested a review from a team February 22, 2024 12:58
@mvaligursky mvaligursky merged commit 2886a90 into main Feb 22, 2024
7 checks passed
@mvaligursky mvaligursky deleted the mv-setshader-refactor branch February 22, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @willeastcott