-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rollup import transform #6090
Merged
Merged
+27
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marklundin
requested review from
kungfooman,
mvaligursky,
slimbuck and
kpal81xd
February 26, 2024 13:43
mvaligursky
reviewed
Feb 26, 2024
mvaligursky
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, but please give some time for additional opinions before merging.
@kungfooman perhaps?
kungfooman
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good 👍
kpal81xd
reviewed
Feb 26, 2024
Co-authored-by: KPal <48248865+kpal81xd@users.noreply.github.com>
kpal81xd
approved these changes
Feb 28, 2024
slimbuck
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a long standing issue with the UMD build not running on devices without dynamic
import()
support. See #6011.This issue stemmed from the use of dynamic
import()
statement, whereimport
is a reserved keyword and would throw a SyntaxError during parsing on older browsers, even if the code path was never executed.This PR adds a rollup transform to the UMD build only, which wraps
import()
statements in a dynamic function. This is only evaluated at runtime, thereby avoiding the parsing on load error. Note that this does not polyfill dynamic imports, it will simply prevent parsing errors on browser without support.Caveats
This does put a limitation on CSP for UMD builds, however this only applies if all of the following conditions are met
unsafe-eval
in their CSP ANDI confirm I have read the contributing guidelines and signed the Contributor License Agreement.