Added worker environment #6108
Merged
Added worker environment #6108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marklundin
requested review from
slimbuck,
willeastcott and
mvaligursky
and removed request for
slimbuck
mvaligursky
approved these changes
Mar 5, 2024
|
globalThis is global which works across everything, but it's not available pre Chrome-71 era, so falls back to using |
slimbuck
reviewed
Mar 8, 2024
| * | ||
| * @type {object} | ||
| */ | ||
| global: (environment === 'browser') ? window : global, | ||
| global: globalThis ?? |
There was a problem hiding this comment.
Won't this throw on browsers that didn't support globalThis? You might need to do typeof globalThis !== undefined before attempting to reference it.
There was a problem hiding this comment.
Yes you're 100% right. Good spot. Will patch this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user script is parsed in the editor, it's executed in a Worker which doesn't have
windoworglobal.This means that when the following ESM Script is parsed in the editor, it will import the engine and immediately throw because neither
windownorglobalexists.This PR adds
environment: 'worker'andglobal: selfas additional values which prevents this error.