Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed class replacement typefix #6140

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Removed class replacement typefix #6140

merged 4 commits into from
Mar 12, 2024

Conversation

kpal81xd
Copy link
Contributor

@kpal81xd kpal81xd commented Mar 11, 2024 •
edited
Loading

Removed Class wrapper and uses import with typeof directly instead of finding and replacing in types

  • TS linter
  • API reference

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@kpal81xd kpal81xd self-assigned this Mar 11, 2024
@kpal81xd kpal81xd requested a review from willeastcott March 11, 2024 14:31
willeastcott
willeastcott approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great...and you're certain the types and docs don't suffer any problems/changes because of this?

@kpal81xd
Copy link
Contributor Author

kpal81xd commented Mar 12, 2024 •
edited
Loading

This looks great...and you're certain the types and docs don't suffer any problems/changes because of this?

Actually the typedoc now displays the correct type (it current shows any)

e.g. findScript
image

@kpal81xd kpal81xd merged commit dcd2634 into main Mar 12, 2024
7 checks passed
@kpal81xd kpal81xd deleted the types-class branch March 12, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@kpal81xd kpal81xd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpal81xd @willeastcott