Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CollisionComponent properties port to get/set #6164

Merged
merged 5 commits into from
Mar 15, 2024
Merged

CollisionComponent properties port to get/set #6164

merged 5 commits into from
Mar 15, 2024

Conversation

kpal81xd
Copy link
Contributor

Port of CollisionComponent from using Object.defineProperty to using get/set

  • TS linter
  • API reference

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@kpal81xd kpal81xd requested review from a team and willeastcott March 14, 2024 16:58
@kpal81xd kpal81xd self-assigned this Mar 14, 2024
@kpal81xd kpal81xd merged commit 4101f90 into main Mar 15, 2024
7 checks passed
@kpal81xd kpal81xd deleted the types-collision branch March 15, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeXXik LeXXik LeXXik left review comments

@willeastcott willeastcott willeastcott approved these changes

Assignees

@kpal81xd kpal81xd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpal81xd @willeastcott @LeXXik