Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed circular self dependency #6168

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Removed circular self dependency #6168

merged 1 commit into from
Mar 15, 2024

Conversation

kpal81xd
Copy link
Contributor

@kpal81xd kpal81xd commented Mar 15, 2024

Fixes yarn install issue https://forum.playcanvas.com/t/engine-release-v1-69-0/35174/12

Removes circular dependency file:. in package.json

N.B Using extras will now break due to playcanvas dependency not being resolved.

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@kpal81xd kpal81xd requested review from a team and marklundin March 15, 2024 12:15
@kpal81xd kpal81xd self-assigned this Mar 15, 2024
@kpal81xd kpal81xd added the bug label Mar 15, 2024
@kpal81xd kpal81xd merged commit 1aa8d27 into main Mar 15, 2024
7 checks passed
@kpal81xd kpal81xd deleted the remove-self-dep branch March 15, 2024 12:38
mvaligursky pushed a commit that referenced this pull request Mar 15, 2024
# Conflicts:
#	package.json
@willeastcott
Copy link
Contributor

It looks like package-lock.json was not updated in this PR. I'll do a follow up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants