Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up Karma tests #6175

Merged
merged 3 commits into from
Mar 16, 2024
Merged

Tidy up Karma tests #6175

merged 3 commits into from
Mar 16, 2024

Conversation

willeastcott
Copy link
Contributor

  • Remove code related to testing the unbuilt source. This hasn't worked in many years.
  • Initialize Mocha, Chai and Sinon correctly.
  • Remove aliases for Chai function calls.

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@willeastcott willeastcott requested a review from slimbuck March 16, 2024 10:41
@willeastcott willeastcott self-assigned this Mar 16, 2024
@willeastcott willeastcott merged commit e45f15d into main Mar 16, 2024
7 checks passed
@willeastcott willeastcott deleted the karma-tidy branch March 16, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

Assignees

@willeastcott willeastcott

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willeastcott @slimbuck