-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of StorageBuffer on WebGPU #6201
Conversation
// format of a bind group, providing resources for the compute shader | ||
computeBindGroupFormat: new pc.BindGroupFormat(device, [ | ||
// no uniform buffer | ||
], [ | ||
// input texture - the scene color map | ||
new pc.BindTextureFormat('uSceneColorMap', pc.SHADERSTAGE_COMPUTE) | ||
], [ | ||
// no storage textures | ||
], [ | ||
// output storage buffer | ||
new pc.BindStorageBufferFormat('outBuffer', pc.SHADERSTAGE_COMPUTE) | ||
]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This array format seems v messy maybe replace with an object with keys to describe each array?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah good suggestion, but outside of the scope of this PR.
Co-authored-by: Will Eastcott <will@playcanvas.com>
Co-authored-by: Will Eastcott <will@playcanvas.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with minor comments. Nice! 👏
Co-authored-by: Will Eastcott <will@playcanvas.com>
related to #6009
intended public API