Clear vertex buffer on empty instance buffer inside drawInstance #6208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles a corner case that we found when doing instanced draw calls.
Inside the
Renderer.drawInstance
method if theinstancingData.count
is zero there is nodevice.draw
called which leaves theGraphicsDevice.vertexBuffers
list uncleared (that list is only cleared on a successful draw call) thus making next draw call to bind more vertex buffers then needed (plus create extra temporary VAOs) and in some cases if the material changes from a draw call to the next and it has different attribute requirements it breaks the draw call (sometimes with visible artifacts) and WebGL logs warnings:It took a long time to figure this one out so we're hoping this PR would benefit others who also rely a lot on instancing.
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.