Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSplat rendering no longer uses instancing #6213

Merged
merged 4 commits into from
Apr 2, 2024
Merged

GSplat rendering no longer uses instancing #6213

merged 4 commits into from
Apr 2, 2024

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Apr 2, 2024 •
edited
Loading

  • It seems instancing was not the most efficient way to render gsplat quads, possibly due to many GPUs not supporting executing vertex shader of different instances in the same wave. Performance gain is 10% on my M1 Max.
  • at this stage, this no longer supports WebGL1, as it does not provide VertexID in vertex shader (not that this can be worked around by providing it ourselves in the VB, but has not been done)
  • added support for asInt attribute to Mesh API (it was already supported by VertexFormat API)

@mvaligursky mvaligursky self-assigned this Apr 2, 2024
@mvaligursky mvaligursky added performance Relating to load times or frame rate area: graphics Graphics related issue labels Apr 2, 2024
@mvaligursky mvaligursky requested a review from a team April 2, 2024 10:33
@mvaligursky mvaligursky merged commit 48f9551 into main Apr 2, 2024
7 checks passed
@mvaligursky mvaligursky deleted the mv-splat-no-instancing branch April 2, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpal81xd kpal81xd kpal81xd approved these changes

@slimbuck slimbuck slimbuck approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue performance Relating to load times or frame rate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvaligursky @slimbuck @kpal81xd