Updated handling of defines specified by a shader definition #6253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willeastcott
approved these changes
Apr 15, 2024
|
The problem this does not solve is the fact that WGSL does not support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change #6250 introduced shader handling a map of includes and defines. The defines map was directly passed to the preprocessor, which used it internally when handling
#ifdeftype of code.As our preprocessor does not handle generic defines, for example
#define LOD_LEVEL 4which can then be used anywhere in the following code, the implementation has changed to allow this.This PR converts all defines specified in the define map to source code, and this is attached to the shader source code directly. This allows us to pass on processing of those defines to the actual platforms that compiles the shader.