Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require all supported WebGPU limits when creating a device #6255

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Require all supported WebGPU limits when creating a device #6255

merged 2 commits into from
Apr 16, 2024

Conversation

mvaligursky
Copy link
Contributor

  • we were getting just a default limits, but can get higher limits if requesting them.

@mvaligursky mvaligursky self-assigned this Apr 15, 2024
@mvaligursky mvaligursky added area: graphics Graphics related issue enhancement labels Apr 15, 2024
@mvaligursky mvaligursky requested a review from a team April 15, 2024 15:45
slimbuck
slimbuck approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@slimbuck slimbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any idea why this isn't default behaviour?

@mvaligursky
Copy link
Contributor Author

any idea why this isn't default behaviour?

The only reason to not require better limits is when testing to ensure it works on all WebGPU supported devices.

@mvaligursky mvaligursky merged commit 4f87dd2 into main Apr 16, 2024
7 checks passed
@mvaligursky mvaligursky deleted the mv-webgpu-required-limits branch April 16, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @slimbuck