Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DomeGeometry for the skydome rendering - refactor #6266

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Apr 19, 2024

As the Geometry functionality allows us to generate a sphere geometry without constructing a mesh from it, avoid cloning the sphere generation with some modifications when creating a dome, but simply post-process the generated sphere geometry.

Exposed to public as well as this can be useful.

Generates the same skydome as before:
Screenshot 2024-04-19 at 13 50 20

@mvaligursky mvaligursky added area: graphics Graphics related issue enhancement labels Apr 19, 2024
@mvaligursky mvaligursky self-assigned this Apr 19, 2024
@mvaligursky mvaligursky requested a review from a team April 19, 2024 13:04
@mvaligursky mvaligursky merged commit b768358 into main Apr 19, 2024
7 checks passed
@mvaligursky mvaligursky deleted the mv-dome-geom branch April 19, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants