Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converted skydome shader generator to use defines and includes #6269

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Converted skydome shader generator to use defines and includes #6269

merged 1 commit into from
Apr 22, 2024

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Apr 19, 2024 •
edited
Loading

  • no change to the generated shaders
  • using processor with defines and includes to put the shader together

Ideally we'd inline both skyboxHDR and skyboxEnv chunks into a singe chunk with includes, to make this a lot nicer, but that's for a separate PR.

@mvaligursky mvaligursky self-assigned this Apr 19, 2024
@mvaligursky mvaligursky added area: graphics Graphics related issue enhancement labels Apr 19, 2024
@mvaligursky mvaligursky requested a review from a team April 19, 2024 15:48
@mvaligursky mvaligursky merged commit cd005b0 into main Apr 22, 2024
7 checks passed
@mvaligursky mvaligursky deleted the mv-skydome-shadergen branch May 17, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @slimbuck