Revert "Add Script alias (#6237)" #6355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dd65f24.
willeastcott
approved these changes
May 13, 2024
slimbuck
pushed a commit
to slimbuck/engine
that referenced
this pull request
May 20, 2024
This reverts commit dd65f24.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to #6316 it is not possible to extend the current
ScriptTypeclass using ES class syntax. This makes it impossible to use with ESM Scripts.This PR therefore reverts the commit dd65f24 and removes the
Scriptaliasing ofScriptType. TheScriptclass will now become it's own concrete base class compatible with ESM class scripts. This will included in a followup PR.I confirm I have read the contributing guidelines and signed the Contributor License Agreement.