Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fixes for 1.70 #6360

Merged
merged 2 commits into from
May 14, 2024
Merged

Build fixes for 1.70 #6360

merged 2 commits into from
May 14, 2024

Conversation

kpal81xd
Copy link
Contributor

@kpal81xd kpal81xd commented May 14, 2024

Includes #6340 changes for 1.70

@kpal81xd kpal81xd self-assigned this May 14, 2024
Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
engine ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 0:37am

@kpal81xd
Copy link
Contributor Author

@mvaligursky I made sure to only include those same changes in case you are merging in other build changes to 1.70

Copy link
Contributor

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I assume this was well tested against 1.70

@kpal81xd
Copy link
Contributor Author

Looks good. I assume this was well tested against 1.70

Yep checked the build and the importing too with ts and vite

@kpal81xd kpal81xd merged commit cf5254b into release-1.70 May 14, 2024
1 of 2 checks passed
@kpal81xd kpal81xd deleted the build-fixes-1.70 branch May 14, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants